netdev - Re: 2.6.23-rc8-mm2 BUG: register_netdevice() issue as (ab)used by ISDN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071008103902.1fc6ff7c@freepuppy.rosehill>
Date:	Mon, 8 Oct 2007 10:39:02 -0700
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Karsten Keil <kkeil@...e.de>
Cc:	isdn4linux@...tserv.isdn4linux.de, netdev@...r.kernel.org
Subject: Re: 2.6.23-rc8-mm2 BUG: register_netdevice() issue as (ab)used by
 ISDN

On Mon, 8 Oct 2007 13:48:44 +0200
Karsten Keil <kkeil@...e.de> wrote:

> On Sun, Oct 07, 2007 at 02:06:53PM +0200, Andreas Mohr wrote:
> > [not necessarily a very recent regression, used 2.6.19 kernels before...]
> > 
> > Hi all,
> > 
> > wondered why my main internet server (headless!) didn't come up properly
> > on a new 2.6.23-rc8-mm2
> ...
> > as if it's the
> >        BUG_ON(!dev->nd_net);
> > check which caused the BUG message.
> 
> The regression comes from the net namespace patches.
> Up to now in ISDN the struct netdevice is contained in struct isdn_net_dev and so
> it's not allocated using alloc_netdev(), which would set the missing dev->nd_net
> pointer.
> 
> 

Then ISDN is BROKEN in existing code.  ALL network devices must be allocated
by alloc_netdev() not the device driver otherwise there is no way to prevent
oopsing through sysfs. RTFM Documentation/networking/netdevices.txt

Please fix for 2.6.23 and 2.6.22 stable.

-- 
Stephen Hemminger <shemminger@...ux-foundation.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html