netdev - Re: [PATCH 3/7] [IPSEC]: Move common output code to xfrm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071008.171717.71577244.davem@davemloft.net>
Date:	Mon, 08 Oct 2007 17:17:17 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 3/7] [IPSEC]: Move common output code to xfrm_output

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Mon, 08 Oct 2007 19:29:39 +0800

> [IPSEC]: Move common output code to xfrm_output
> 
> Most of the code in xfrm4_output_one and xfrm6_output_one are identical so
> this patch moves them into a common xfrm_output function which will live
> in net/xfrm.
> 
> In fact this would seem to fix a bug as on IPv4 we never reset the network
> header after a transform which may upset netfilter later on.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied.

Could you submit a 2.6.23 version of just the ipv4 fix?
It might be interesting to determine why it was omitted,
perhaps it was an oversight, and it probably predates the
addition of skb_reset_*().
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html