| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20071008.174603.55855492.davem@davemloft.net> Date: Mon, 08 Oct 2007 17:46:03 -0700 (PDT) From: David Miller <davem@...emloft.net> To: eliezert@...adcom.com Cc: jeff@...zik.org, netdev@...r.kernel.org, mchan@...adcom.com Subject: Re: [PATCH 1/8][BNX2X] resubmit as attachments: add bnx2x to Kconfig and Makefile From: "Eliezer Tamir" <eliezert@...adcom.com> Date: Mon, 08 Oct 2007 18:15:17 +0200 > Add bnx2x to Kconfig and Makefile In a patch submission, the tree should build on every step along the way in applying your patches, with any given configuration. Here, the user (or something automated like "make allmodconfig") can select the new config option, but because the driver source hasn't been added, the compile will fail. The idea is that if your patch set really is composed of logically seperate changes, you submit them one logical compilable piece at a time, and if the first few patches are ok, they could go right in whilst we work out issues in later patches. But that's not how a new driver is, it is logically one change only. You go on next to add a foo.c file, and then a foo.h file. This makes things even more difficult to review. Really, for a new driver that doesn't make any generic kernel code changes, just submit the whole thing in one shot. It's the only reasonable way. Thank you. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists