netdev - Re: [PATCH]race between open and disconnect in irda-usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071011162311.GA26354@bougret.hpl.hp.com>
Date:	Thu, 11 Oct 2007 09:23:11 -0700
From:	Jean Tourrilhes <jt@....hp.com>
To:	Oliver Neukum <oliver@...kum.org>, Samuel Ortiz <samuel@...tiz.org>
Cc:	Nick Fedchik <nick@...chik.org.ua>, netdev@...r.kernel.org,
	USB development list <linux-usb-devel@...ts.sourceforge.net>
Subject: Re: [PATCH]race between open and disconnect in irda-usb

On Thu, Oct 11, 2007 at 05:45:28PM +0200, Oliver Neukum wrote:
> Hi,
> 

	Hi,

	You need to cc Samuel Ortiz and the IrDA mailing list if you
want any meaningful response.

> it seems to me that irda_usb_net_open() must set self->netopen
> under spinlock or disconnect() may fail to kill all URBs.

	I believe to patch is correct, but in practice I fail to see
how it could happen. Anyway, Samuel will have the final word.

> Signed-off-by: Oliver Neukum <oneukum@...e.de>
> 
> 	Regards
> 		Oliver

	Have fun...

	Jean

> ----
> 
> --- a/drivers/net/irda/irda-usb.c	2007-10-11 17:24:35.000000000 +0200
> +++ b/drivers/net/irda/irda-usb.c	2007-10-11 17:30:30.000000000 +0200
> @@ -1168,6 +1168,7 @@ static int stir421x_patch_device(struct 
>  static int irda_usb_net_open(struct net_device *netdev)
>  {
>  	struct irda_usb_cb *self;
> +	unsigned long flags;
>  	char	hwname[16];
>  	int i;
>  	
> @@ -1177,13 +1178,16 @@ static int irda_usb_net_open(struct net_
>  	self = (struct irda_usb_cb *) netdev->priv;
>  	IRDA_ASSERT(self != NULL, return -1;);
>  
> +	spin_lock_irqsave(&self->lock, flags);
>  	/* Can only open the device if it's there */
>  	if(!self->present) {
> +		spin_unlock_irqrestore(&self->lock, flags);
>  		IRDA_WARNING("%s(), device not present!\n", __FUNCTION__);
>  		return -1;
>  	}
>  
>  	if(self->needspatch) {
> +		spin_unlock_irqrestore(&self->lock, flags);
>  		IRDA_WARNING("%s(), device needs patch\n", __FUNCTION__) ;
>  		return -EIO ;
>  	}
> @@ -1198,6 +1202,7 @@ static int irda_usb_net_open(struct net_
>  	/* To do *before* submitting Rx urbs and starting net Tx queue
>  	 * Jean II */
>  	self->netopen = 1;
> +	spin_unlock_irqrestore(&self->lock, flags);
>  
>  	/* 
>  	 * Now that everything should be initialized properly,
> 
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html