netdev - Re: e100 problems in .23rc8 ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071011172551.GA21339@redhat.com>
Date:	Thu, 11 Oct 2007 13:25:51 -0400
From:	Dave Jones <davej@...hat.com>
To:	"Kok, Auke" <auke-jan.h.kok@...el.com>
Cc:	Herbert Xu <herbert.xu@...hat.com>, netdev@...r.kernel.org,
	esandeen@...hat.com, dmack@...iper.net
Subject: Re: e100 problems in .23rc8 ?

On Thu, Oct 11, 2007 at 09:10:34AM -0700, Kok, Auke wrote:
 > Herbert Xu wrote:
 > > On Wed, Oct 10, 2007 at 08:36:38PM -0400, Dave Jones wrote:
 > >> The e1000 changes you reference above, is this the changeset you mean?
 > >>
 > >> commit 416b5d10afdc797c21c457ade3714e8f2f75edd9
 > >> Author: Auke Kok <auke-jan.h.kok@...el.com>
 > >> Date:   Fri Jun 1 10:22:39 2007 -0700
 > >>
 > >>     e1000: disable polling before registering netdevice
 > > 
 > > Yep.
 > 
 > this patch actually called napi_disable() in the probe routine which was wrong,
 > but e100 does not do that. Nonetheless e100 doesn't call netif_carrier_off() and
 > netif_stop_queue(), so to make e100 the same as e1000 we should probably do this,
 > see below.
 > 
 > Dave, can you see if this resolves the issue for you? If so then we might want to
 > push this to -stable.
 
Will do, thanks Auke.

Eric/David, the Fedora 8 RPM version 2.6.23-6.fc8 will have this if you
want to give it a shot too.  It'll be at
http://people.redhat.com/davej/kernels/Fedora/f7.92/ when it's done
building in an hour or so.

	Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html