netdev - Re: [PATCH 10/12] Fix off-by-one in print of wrandom algo.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071012143910.4e6050bf@freepuppy.rosehill>
Date:	Fri, 12 Oct 2007 14:39:10 -0700
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Andreas Henriksson <andreas@...al.se>
Cc:	netdev@...r.kernel.org, Norbert Buchmuller <norbi@....hu>,
	Andreas Henriksson <andreas@...al.se>
Subject: Re: [PATCH 10/12] Fix off-by-one in print of wrandom algo.

On Fri, 12 Oct 2007 10:56:45 +0200
Andreas Henriksson <andreas@...al.se> wrote:

> From: Norbert Buchmuller <norbi@....hu>
> 
> The 'wrandom' multipath algo is recognised when adding the route, but
> not resolved when it is printed (prints 'unknown'):
> 
> ianus:~# ip ro add 1.2.3.4 mpath wrandom nexthop dev ppp0 weight 1 nexthop dev ppp1 weight 2
> ianus:~# ip ro get to 1.2.3.4
> 1.2.3.4 mpath unknown dev ppp0  src 62.77.192.67
>     cache  mtu 1492 advmss 1452 hoplimit 64
> ianus:~# ip ro del 1.2.3.4 mpath wrandom nexthop dev ppp0 weight 1 nexthop dev ppp1 weight 2
> 
> See http://bugs.debian.org/428440 for more information.
> 
> Signed-off-by: Andreas Henriksson <andreas@...al.se>
> ---
>  ip/iproute.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/ip/iproute.c b/ip/iproute.c
> index d3a3243..3b5c4b1 100644
> --- a/ip/iproute.c
> +++ b/ip/iproute.c
> @@ -365,7 +365,7 @@ int print_route(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
>  		__u32 mp_alg = *(__u32*) RTA_DATA(tb[RTA_MP_ALGO]);
>  		if (mp_alg > IP_MP_ALG_NONE) {
>  			fprintf(fp, "mpath %s ",
> -			    mp_alg < IP_MP_ALG_MAX ? mp_alg_names[mp_alg] : "unknown");
> +			    mp_alg <= IP_MP_ALG_MAX ? mp_alg_names[mp_alg] : "unknown");
>  		}
>  	}
>  

Actually since multi-path was removed from kernel, I just pulled support
for it from current iproute

-- 
Stephen Hemminger <shemminger@...ux-foundation.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html