netdev - Re: Regression in net-2.6.24?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071011.180352.71088951.davem@davemloft.net>
Date:	Thu, 11 Oct 2007 18:03:52 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...ux-foundation.org
Cc:	takano@...-inc.co.jp, netdev@...r.kernel.org,
	ilpo.jarvinen@...sinki.fi, mchan@...adcom.com
Subject: Re: Regression in net-2.6.24?

From: David Miller <davem@...emloft.net>
Date: Thu, 11 Oct 2007 18:00:31 -0700 (PDT)

> From: Stephen Hemminger <shemminger@...ux-foundation.org>
> Date: Thu, 11 Oct 2007 17:50:59 -0700
> 
> > On Thu, 11 Oct 2007 17:40:26 -0700 (PDT)
> > David Miller <davem@...emloft.net> wrote:
> > 
> > > From: Stephen Hemminger <shemminger@...ux-foundation.org>
> > > Date: Thu, 11 Oct 2007 17:31:49 -0700
> > > 
> > > > You don't need to re-read the status register and process the PHY irq's inside loop.
> > > > Try this:
> > > 
> > > Are you sure?  What if a PHY interrupt comes in during the loop?
> > 
> > The interrupt is level triggered, and will rearm.
> 
> Fair enough.

Actually, your change isn't right for another reason.

You missed the necessary budget reducing logic that I used
in the original changes.  You need to adjust work_limit
like this:

		work_done += sky2_status_intr(hw, work_limit - work_done);

Otherwise if you just pass plain "work_limit", and we do loop, the
driver uses more quota than it really should.

And I've made that above correction to your patch in my tree.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html