netdev - Re: iproute2: resend of patches from Debian.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071012055540.GF30784@ned.snow-crash.org>
Date:	Fri, 12 Oct 2007 07:55:40 +0200
From:	Alexander Wirt <formorer@...morer.de>
To:	Lennart Sorensen <lsorense@...lub.uwaterloo.ca>
Cc:	Andreas Henriksson <andreas@...al.se>, netdev@...r.kernel.org
Subject: Re: iproute2: resend of patches from Debian.

Lennart Sorensen schrieb am Donnerstag, den 11. Oktober 2007:

> On Thu, Oct 11, 2007 at 08:25:32PM +0200, Andreas Henriksson wrote:
> > Patch from debian iproute package.
> > 
> > diff -urNad iproute-20060323~/ip/iplink.c iproute-20060323/ip/iplink.c
> > --- iproute-20060323~/ip/iplink.c	2006-03-22 00:57:50.000000000 +0100
> > +++ iproute-20060323/ip/iplink.c	2006-09-08 21:07:14.000000000 +0200
> > @@ -384,6 +384,10 @@
> >  	}
> >  
> >  	if (newname && strcmp(dev, newname)) {
> > +		if (strlen(newname) == 0) {
> > +		    printf("\"\" is not valid device identifier\n",dev);
> > +		    return -1;
> > +		}
> >  		if (do_changename(dev, newname) < 0)
> >  			return -1;
> >  		dev = newname;
> 
> Isn't that printf missing somewhere for the 'dev' argument to go?
Uhm, yes you are right. It don't hurts but its useless, so the 'dev' argument
should be removed. 

Thanks
Alex

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html