lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [day] [month] [year] [list]
Date:	Fri, 12 Oct 2007 16:58:17 -0700
From:	Justin Pettit <jpettit@...ira.com>
To:	netdev@...r.kernel.org
Subject: Issue in __vlan_put_tag?

The function __vlan_put_tag modifies adds a VLAN tag to an existing  
Ethernet packet.  In the process, the front of the packet is extended  
by four bytes to accommodate the tag.  This function correctly  
adjusts the mac_header offset, but I think this line is problematic:

	skb->network_header -= VLAN_HLEN;

When access to the network header is needed, the value of skb- 
 >network_header is added to skb->head, which should not have changed  
during any of the previous modifications.  I believe the code as it  
exists now will cause the network header to appear to be four bytes  
earlier than it actually is.

--Justin
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists