netdev - Re: net-2.6.24 breaks powerpc mysteriously

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 14 Oct 2007 04:40:46 +0100
From:	Denys Vlasenko <vda.linux@...glemail.com>
To:	David Miller <davem@...emloft.net>
Cc:	akpm@...ux-foundation.org, netdev@...r.kernel.org,
	sam@...nborg.org, paulus@...ba.org, benh@...nel.crashing.org
Subject: Re: net-2.6.24 breaks powerpc mysteriously

On Friday 12 October 2007 03:45, David Miller wrote:
> From: Andrew Morton <akpm@...ux-foundation.org>
> Date: Thu, 11 Oct 2007 19:22:33 -0700
> 
> > With net-2.6.24 (pulled yesterday) applied:
> > 
> > g5:/usr/src/25> ml arch/powerpc/boot/inflate.o
> >   Using ARCH=powerpc CROSS_COMPILE=
> >   CHK     include/linux/version.h
> >   CHK     include/linux/utsrelease.h
> >   CALL    scripts/checksyscalls.sh
> >   BOOTCC  arch/powerpc/boot/inflate.o
> > arch/powerpc/boot/inflate.c:920:19: errno.h: No such file or directory
> > arch/powerpc/boot/inflate.c:921:18: slab.h: No such file or directory
> > arch/powerpc/boot/inflate.c:922:21: vmalloc.h: No such file or directory
> > arch/powerpc/boot/inflate.c: In function `zlib_inflate_blob':
> > arch/powerpc/boot/inflate.c:928: error: syntax error before '*' token
> 
> The only thing we touched in zlib is in the patch below.
> 
> I suspect the lib/zlib_inflate/inflate.c changes, I had no idea that
> some pieces of code try to use this into userspace.
> 
> I supposed a hacky fix is to add __KERNEL__ ifdef protection around
> zlib_inflate_blob() and those troublesome includes.  A nicer fix is
> probably to change the zlib_inflate_blob() interface to pass in
> pointers to alloc() and free() routines instead of calling kernel ones
> directly.
> 
> Denys?
> 
> commit 8336793baf962163c9fab5a3f39614295fdbab27
> Author: Denys Vlasenko <vda.linux@...glemail.com>
> Date:   Sun Sep 30 17:56:49 2007 -0700
> 
>     [ZLIB]: Move bnx2 driver gzip unpacker into zlib.
>     
>     Signed-off-by: Denys Vlasenko <vda.linux@...glemail.com>
>     Acked-by: Michael Chan <mchan@...adcom.com>
>     Signed-off-by: David S. Miller <davem@...emloft.net>

Please find updated patch in attachment.
Compile-tested.
--
vda

View attachment "new.diff" of type "text/x-diff" (8481 bytes)