netdev - Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071015135959.5b603d7d@weaponx.rchland.ibm.com>
Date:	Mon, 15 Oct 2007 13:59:59 -0500
From:	Josh Boyer <jwboyer@...ux.vnet.ibm.com>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	Valentine Barshak <vbarshak@...mvista.com>,
	Michael Ellerman <michael@...erman.id.au>,
	linuxppc-dev@...abs.org, netdev@...r.kernel.org
Subject: Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to
 NEW EMAC.

On Mon, 15 Oct 2007 14:53:26 -0400
Jeff Garzik <jeff@...zik.org> wrote:
> >> Seems sane to me -- ACK -- but we have multiple people sending me 
> >> patches for a single driver.  That's normal for janitorial cleanups 
> >> across the whole tree, but discouraged when multiple people are actively 
> >> working on the same driver.
> >>
> >> Please coordinate, and have ONE person send me patches...
> > 
> > Who else is sending you patches?  Valentine is the only one I've seen
> > send patches recently...
> 
> It's a zoo :)

Wow, indeed.

> Al Viro (3):
>        typo in ibm_newemac/rgmii.c

Val sent this as well.  Either one works.

>        skb->tail in ibm_newemac should be skb_tail_pointer()
>        ibm_newemac annotations (iomem, NULL noise)

Ack on those.

> David Gibson (1):
>        Device tree aware EMAC driver

That's the initial commit :)

> Michael Ellerman (3):
>        Update ibm_newemac to use dcr_host_t.base
>        Add dcr_host_t.base in dcr_read()/dcr_write()
>        Use dcr_host_t.base in dcr_unmap()

Missed those, but I see you applied them which is good.

> Roland Dreier (2):
>        ibm_new_emac: Nuke SET_MODULE_OWNER() use
>        ibm_emac: Convert to use napi_struct independent of struct net_device

I never saw either of these.  I'm also beginning to wonder if one of
them broke things because I can't currently get ibm_newemac to work.

> vbarshak@...mvista.com (1):
>        Fix typo in new EMAC driver.

Same fix as Al's.

Anyway, we can queue patches to this through me if you'd like.

josh
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html