netdev - Re: [PATCH][BNX2X] round three

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071015.123850.26516814.davem@davemloft.net>
Date:	Mon, 15 Oct 2007 12:38:50 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eliezert@...adcom.com
Cc:	andi@...stfloor.org, netdev@...r.kernel.org, jeff@...zik.org,
	mchan@...adcom.com
Subject: Re: [PATCH][BNX2X] round three

From: "Eliezer Tamir" <eliezert@...adcom.com>
Date: Mon, 15 Oct 2007 17:27:29 +0200

> Unfortunately, the firmware code is different for LE and BE machines.
> We had issues with the BE firmware that appear to be resolved.
> Hopefully, the next version will have both.

If this means we get two copies of the firmware, this should be
rethought.  The space cost of the firmware (both in terms of source
code size and object code size) is already enormous.

I would definitely prefer if there were only little-endian firmware,
and the driver uses "cpu_to_le32()" and friends to access chip shared
data structures.

Most cpus have endian swapping loads and stores, accessible via
cpu_to_le32p() and similar interfaces, so the cost on big-endian of
doing things this way is very close to zero.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html