netdev - Re: [PATCH] Disable polling in rtl8169_suspend() to prevent race with rtl8169

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200710162127.52228.fzu@wemgehoertderstaat.de>
Date:	Tue, 16 Oct 2007 21:27:51 +0200
From:	Karsten Wiese <fzu@...gehoertderstaat.de>
To:	romieu@...zoreil.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] Disable polling in rtl8169_suspend() to prevent race with rtl8169_interrupt()

Am Dienstag, 16. Oktober 2007 schrieb Karsten Wiese:
> Hi,
> 
> Sometimes (~ 1 in 10) after suspend to disk my r8169 nic doesn't work and a
> "r8169: eth0: link down" gets mingled up with those suspend messages.
> First tests show nothing bad, so maybe this patch really helps.
> Will post again, if it doesn't.
> 
>       Karsten
> ------------------>
> 
> Disable polling in rtl8169_suspend() to prevent race with rtl8169_interrupt()
> 
> rtl8169_interrupt() is called during polling.
> Without patch, rtl8169_interrupt() could run after rtl8169_asic_down(),
> causing a disabled link state being saved later in rtl8169_suspend() by
> pci_save_state().
> netif_stop_queue() can go as it is called by netif_device_detach().
> 
> Signed-off-by: Karsten Wiese <fzu@...gehoertderstaat.de>

Forgot to say: patch is against 2.6.23. Stable material, if it gets an ACK.
The BUG happens since months here, if not since I hibernate this pc.

git HEAD would need a similar fix I think, haven't tried yet.

      Karsten
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html