netdev - Re: [PATCH/RFC] net: Add __napi_sycnhronize() to sync with napi poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1IhfZr-0002FE-00@gondolin.me.apana.org.au>
Date:	Tue, 16 Oct 2007 14:06:51 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	benh@...nel.crashing.org
Cc:	shemminger@...ux-foundation.org, netdev@...r.kernel.org,
	davem@...emloft.net, rdreier@...co.com, linuxppc-dev@...abs.org
Subject: Re: [PATCH/RFC] net: Add __napi_sycnhronize() to sync with napi poll

Benjamin Herrenschmidt <benh@...nel.crashing.org> wrote:
>
> Note: I use msleep_interruptible(1); just like napi_disable(). However
> I'm not too happy that the "hot" loop that results of a pending signal
> here will spin without even a cpu_relax ... what do you guys think would
> be the best way to handle this ?

Well since the loop does not check signals at all, it should
just use msleep.

Granted the process will end up in the D state and contribute
to the load average.  But if this loop executes long enough
for that to be noticed then we've got bigger problems to worry
about.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html