lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <1192530482.4480.17.camel@localhost> Date: Tue, 16 Oct 2007 06:28:02 -0400 From: jamal <hadi@...erus.ca> To: Alexey Kuznetsov <kuznet@....inr.ac.ru> Cc: Herbert Xu <herbert@...dor.apana.org.au>, Patrick McHardy <kaber@...sh.net>, David Miller <davem@...emloft.net>, netdev@...r.kernel.org Subject: Re: [PATCH 5/10] [NET]: Avoid unnecessary cloning for ingress filtering On Mon, 2007-15-10 at 18:55 +0400, Alexey Kuznetsov wrote: > Hello! Didnt mean to wake you up Alexey ;-> > I see not so many places inside net/sched/act* where skb_clone is used. > Exactly one in act_mirred.c, to be more exact. Did I miss something? No you are right, thats the only spot at the moment. What i meant however was the design-intent/enviromental-rules for all actions that branch is to clone, and when you do that you reset those fields i described. I am looking at the new clone and i can see Herbert's point - it does look less pleasant to stare at with that #ifdef; i will send a patch to pull it out and also write a small doc to describe the environmental rules. cheers, jamal - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists