lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20071016125134.GA11319@gondor.apana.org.au> Date: Tue, 16 Oct 2007 20:51:35 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: jamal <hadi@...erus.ca> Cc: David Miller <davem@...emloft.net>, Alexey Kuznetsov <kuznet@....inr.ac.ru>, Patrick McHardy <kaber@...sh.net>, netdev@...r.kernel.org Subject: Re: [PATCH 3/3] [NET_DOC] Document some simple rules for actions On Tue, Oct 16, 2007 at 08:33:31AM -0400, jamal wrote: > > +2) If you munge any packet thou shalt call skb_expand in the case > +someone else is referencing the skb. After that you "own" the skb. > +You must also tell us if it is ok to munge the packet (TC_OK2MUNGE), > +this way any action downstream can stomp on the packet. Thanks for the documentation! But I still think the distinction between skb_clone and skb_copy_header is wrong. When you munge a packet, it's still going to go back up the stack and be processed along the same path. Therefore you should be calling pskb_expand_head. In other words, this does not explain why skb_copy/pskb_copy and skb_copy_expand should differ from skb_clone. As far as I can see all these functions should behave in the same manner with respect to tc_verd. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists