lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <1192540951.4480.108.camel@localhost> Date: Tue, 16 Oct 2007 09:22:31 -0400 From: jamal <hadi@...erus.ca> To: Patrick McHardy <kaber@...sh.net> Cc: David Miller <davem@...emloft.net>, Alexey Kuznetsov <kuznet@....inr.ac.ru>, Herbert Xu <herbert@...dor.apana.org.au>, netdev@...r.kernel.org Subject: Re: [PATCH 2/3] [NET_CLS_ACT] Use skb_act_clone On Tue, 2007-16-10 at 14:53 +0200, Patrick McHardy wrote: > jamal wrote: > > [Can't quote for some reason ..] Sorry, trying to be clever with git-format-patch but chickened out sending using git-am - so patch was just attached (Dave seems to be friendly to such an approach when he applies) > I don't think this change is safe since we might loose the > redirect counter and have endless redirect loops. ipip for > example calls skb_realloc_headroom, which clones the skb > when delta > 0, so it seems we really need to copy tc_verd > in skb_clone(). Generally the assumption that drivers don't > clone packets doesn't seem safe. Does the copying of tc_verd in __copy_skb_header() not cover that? cheers, jamal - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists