netdev - Re: [patch] net: avoid race between netpoll and network fast path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071016.210613.71104656.davem@davemloft.net>
Date:	Tue, 16 Oct 2007 21:06:13 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	tina.yang@...cle.com
Cc:	mpm@...enic.com, netdev@...r.kernel.org
Subject: Re: [patch] net: avoid race between netpoll and network fast path

From: Tina Yang <tina.yang@...cle.com>
Date: Tue, 16 Oct 2007 20:45:04 -0700

> The current netpoll design and implementation has serveral race issues with the
> network fast path that panics/hangs the system or causes interface timeout/reset
> but the fix is likely to have impact on the overall system performance and could
> involve a large number of drivers.  The proposal is to disable the problem code
> for normal operations but only to enable it at the time of crash in case polling
> is necessary.  Tests that have been done included the bug fix verification
> as well as regression check on the netlog results in various crash modes.
> 
> Signed-off-by: Tina Yang <tina.yang@...cle.com>

This is at best a kludge, and it's the wrong way to approach this problem.

Fix the bug, and fix it right.

If you disable that stretch of code, what you've done is make the
netpoll code hang and/or drop console messages if the TX queue is full
in the driver and the only way to liberate TX space is to call into
->poll().

You haven't shown the precise race that leads to corruption so that someone
so motivated can guide you towards a more correct fix if you are not
capable of implementing it properly on your own.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html