netdev - Re: [PATCH] Disable polling in rtl8169_suspend() to prevent race with rtl8169

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071017164021.GA13105@electric-eye.fr.zoreil.com>
Date:	Wed, 17 Oct 2007 18:40:21 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Karsten Wiese <fzu@...gehoertderstaat.de>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] Disable polling in rtl8169_suspend() to prevent race
	with rtl8169_interrupt()

Karsten Wiese <fzu@...gehoertderstaat.de> :
[...]
> Can your patch cause the same effect as the "ethtool -s eth0 port mii" in
> the bug case?
> 
> Do you agree that rtl8169_interrupt() should not be called after
> rtl8169_asic_down() when in rtl8169_suspend() and before rtl8169_resume()?

I have not thought about it too deeply.

I'd rather say that the driver must be able to handle it. Spurious/shared
irq happen.

-- 
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html