netdev - Re: [PATCH] [TCP]: Remove lost_retrans zero special cases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071018.195558.103454352.takano@axe-inc.co.jp>
Date:	Thu, 18 Oct 2007 19:55:58 +0900 (JST)
From:	TAKANO Ryousei <takano@...-inc.co.jp>
To:	ilpo.jarvinen@...sinki.fi
Cc:	davem@...emloft.net, y-kodama@...t.go.jp, netdev@...r.kernel.org
Subject: Re: [PATCH] [TCP]: Remove lost_retrans zero special cases

From: "Ilpo Järvinen" <ilpo.jarvinen@...sinki.fi>
Subject: [PATCH] [TCP]: Remove lost_retrans zero special cases
Date: Thu, 18 Oct 2007 13:17:24 +0300 (EEST)

> [PATCH] [TCP]: Remove lost_retrans zero seqno special cases
> 
> Both high-sack detection and new lowest seq variables have
> unnecessary zero special case which are now removed by setting
> safe initial seqnos.
> 
> This also fixes problem which caused zero received_upto being
> passed to tcp_mark_lost_retrans which confused after relations
> within the marker loop causing incorrect TCPCB_SACKED_RETRANS
> clearing. The problem was noticed because of a performance
> report from TAKANO Ryousei <takano@...-inc.co.jp>.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
> ---
>  net/ipv4/tcp_input.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
> index 0f00966..9288220 100644
> --- a/net/ipv4/tcp_input.c
> +++ b/net/ipv4/tcp_input.c
> @@ -1121,7 +1121,7 @@ static int tcp_mark_lost_retrans(struct sock *sk, u32 received_upto)
>  	struct sk_buff *skb;
>  	int flag = 0;
>  	int cnt = 0;
> -	u32 new_low_seq = 0;
> +	u32 new_low_seq = tp->snd_nxt;
>  
>  	tcp_for_write_queue(skb, sk) {
>  		u32 ack_seq = TCP_SKB_CB(skb)->ack_seq;
> @@ -1153,7 +1153,7 @@ static int tcp_mark_lost_retrans(struct sock *sk, u32 received_upto)
>  				NET_INC_STATS_BH(LINUX_MIB_TCPLOSTRETRANSMIT);
>  			}
>  		} else {
> -			if (!new_low_seq || before(ack_seq, new_low_seq))
> +			if (before(ack_seq, new_low_seq))
>  				new_low_seq = ack_seq;
>  			cnt += tcp_skb_pcount(skb);
>  		}
> @@ -1242,7 +1242,7 @@ tcp_sacktag_write_queue(struct sock *sk, struct sk_buff *ack_skb, u32 prior_snd_
>  	int num_sacks = (ptr[1] - TCPOLEN_SACK_BASE)>>3;
>  	int reord = tp->packets_out;
>  	int prior_fackets;
> -	u32 highest_sack_end_seq = 0;
> +	u32 highest_sack_end_seq = tp->lost_retrans_low;
>  	int flag = 0;
>  	int found_dup_sack = 0;
>  	int cached_fack_count;
> -- 
> 1.5.0.6

Thanks Ilpo! This patch solves the problem, as shown below:

iteration :001 .... done. T = 17.365902 BW = 460.672876 Mbps
iteration :002 .... done. T = 16.456351 BW = 486.134501 Mbps
iteration :003 .... done. T = 16.658353 BW = 480.239550 Mbps
iteration :004 .... done. T = 16.468834 BW = 485.766026 Mbps
iteration :005 .... done. T = 16.596055 BW = 482.042268 Mbps

Acked-by: Ryousei Takano <takano-ryousei@...t.go.jp>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html