netdev - Re: [PATCH 1/2] net: Let inet_diag and friends autoload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071017.195125.15264659.davem@davemloft.net>
Date:	Wed, 17 Oct 2007 19:51:25 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jdelvare@...e.de
Cc:	netdev@...r.kernel.org, kuznet@....inr.ac.ru
Subject: Re: [PATCH 1/2] net: Let inet_diag and friends autoload

From: Jean Delvare <jdelvare@...e.de>
Date: Tue, 16 Oct 2007 17:28:23 +0200

> By adding module aliases to inet_diag, tcp_diag and dccp_diag, we let
> them load automatically as needed. This makes tools like "ss" run
> faster.
> 
> Signed-off-by: Jean Delvare <jdelvare@...e.de>
> Cc: Alexey Kuznetsov <kuznet@....inr.ac.ru>
> ---
> The alias naming scheme for tcp_diag and dccp_diag follows what was
> done for dccp_ipv4 and dccp_ipv6.

I'm concerned it might be dangerous to load the module in
this context, the RTNL semaphore is held and the module we
are requesting could easily try to take it and deadlock.

Currently we are lucky and this won't happen, but if the sub-proto
registration is every changed to do so, it will be a nightmare for
whoever is so unlucky to try and debug it.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html