netdev - Re: [PATCH] vortex_up should initialize "err"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071018060506.GA30544@newton.mathematik.tu-chemnitz.de>
Date:	Thu, 18 Oct 2007 08:05:06 +0200
From:	Steffen Klassert <klassert@...hematik.tu-chemnitz.de>
To:	Jeff Garzik <jeff@...zik.org>, akpm@...ux-foundation.org
Cc:	Badari Pulavarty <pbadari@...ibm.com>, netdev@...r.kernel.org,
	lkml <linux-kernel@...r.kernel.org>, satyam@...radead.org
Subject: Re: [PATCH] vortex_up should initialize "err"

On Wed, Oct 17, 2007 at 08:28:36PM -0400, Jeff Garzik wrote:
> Badari Pulavarty wrote:
> >Simple compile warning fix. (against 2.6.23-git12)
> >
> >Thanks,
> >Badari
> >
> >vortex_up() should initialize 'err' for a successful return.
> >
> >drivers/net/3c59x.c: In function `vortex_up':
> >drivers/net/3c59x.c:1494: warning: `err' might be used uninitialized in 
> >this function
> 
> applied as an obvious bug fix (Steffen added to CC)
> 

Hm, we had already the 3c59x-fix-uninitialized-variable-bug.patch from
Satyam Sharma in -mm to fix this, but the patch was removed from -mm
some time ago. Andrew, what happened to this one?

However, this issue should be fixed.

Thanks,

Steffen
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html