netdev - Re: [PATCH 5/8] [MV643XX_ETH] Remove SHARED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071019110907.GK16037@xi.wantstofly.org>
Date:	Fri, 19 Oct 2007 13:09:07 +0200
From:	Lennert Buytenhek <buytenh@...tstofly.org>
To:	Roland Dreier <rdreier@...co.com>
Cc:	Dale Farnsworth <dale@...nsworth.org>,
	Nicolas Pitre <nico@...vell.com>,
	Tzachi Perelstein <tzachi@...vell.com>,
	Manas Saksena <msaksena@...vell.com>, netdev@...r.kernel.org
Subject: Re: [PATCH 5/8] [MV643XX_ETH] Remove SHARED_REGS register address bias

On Thu, Oct 18, 2007 at 08:46:58PM -0700, Roland Dreier wrote:

>  > +static void __iomem *mv643xx_eth_base;
> 
>  > +	return readl(((void __iomem *)mv643xx_eth_base) + offset);
> 
> Given the declaration of mv643xx_eth_base as void __iomem * already, I
> don't understand why you need the cast to the same type here (and
> elsewhere in the driver).

Makes sense, fixed.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html