netdev - Re: [PATCH 2/14 v2] nes: device structures and defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071019222620.1ae322c9@freepuppy.rosehill>
Date:	Fri, 19 Oct 2007 22:26:20 -0700
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Roland Dreier <rdreier@...co.com>
Cc:	ggrundstrom@...effect.com, ewg@...ts.openfabrics.org,
	general@...ts.openfabrics.org, netdev@...r.kernel.org
Subject: Re: [PATCH 2/14 v2] nes: device structures and defines

On Fri, 19 Oct 2007 22:22:44 -0700
Roland Dreier <rdreier@...co.com> wrote:

>  > You are starting off on the wrong foot.
> 
> ???

That was a introductory comment because even in reviewing the first
file (which had almost no code), I saw so many style issues.

>  > > +if(!(expr)) {														\
>  > > +	printk(KERN_ERR PFX "Assertion failed! %s, %s, %s, line %d\n",	\
>  > > +		   #expr, __FILE__, __FUNCTION__, __LINE__);				\
>  > > +}
>  > 
>  > Use BUG_ON
> 
> I agree that there's no need to invent a driver-private assertion
> macro, but (to first order at least) drivers should never use BUG_ON.
> I don't want some glitch in a network driver that the system could
> probably survive to be turned into a panic by BUG_ON -- WARN_ON seems
> infinitely preferable.
> 
>  - R.


-- 
Stephen Hemminger <shemminger@...ux-foundation.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html