netdev - Re: net: alignment problem in icmp code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071022.020538.74751031.davem@davemloft.net>
Date:	Mon, 22 Oct 2007 02:05:38 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	drzeus@...eus.cx
Cc:	netdev@...r.kernel.org
Subject: Re: net: alignment problem in icmp code

From: Pierre Ossman <drzeus@...eus.cx>
Date: Mon, 22 Oct 2007 10:42:08 +0200

> This seems like a rather evil layering violation.

This has a 10+ year precedence and it's why the Linux networking stack
is so fast.  If you read any other driver you would have seen the
skb_reserve() call every one of them do to align the headers.

I think I've tolerated this long enough.

Are you going keep teaching me how the C language works, how GCC
interprets it, and how evil the Linux networking is, or are you going
to fix the bug in your driver? :-)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html