netdev - sch_prio.c vs CONFIG_NETDEVICES

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 23 Oct 2007 16:14:20 +0400
From:	Alexey Dobriyan <adobriyan@...ru>
To:	netdev@...r.kernel.org
Cc:	peter.p.waskiewicz.jr@...el.com, kaber@...sh.net
Subject: sch_prio.c vs CONFIG_NETDEVICES_MULTIQUEUE

gcc spits following warnings

net/sched/sch_prio.c:139: warning: passing argument 2 of 'netif_subqueue_stopped' makes pointer from integer without a cast
net/sched/sch_prio.c:169: warning: passing argument 2 of 'netif_subqueue_stopped' makes pointer from integer without a cast

and he is dead right -- passing integer instead of skb is not going to
work:

	if (!netif_subqueue_stopped(sch->dev, (q->mq ? prio : 0))) {

skb_get_queue_mapping will ignore it if multiqueue support is off and
dereference it otherwise.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html