netdev - Re: Regression in current git - Network Manager fails (bisected)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <471DF28D.3030904@sw.ru>
Date:	Tue, 23 Oct 2007 17:09:33 +0400
From:	"Denis V. Lunev" <den@...ru>
To:	Thomas Graf <tgraf@...g.ch>
CC:	Dan Williams <dcbw@...hat.com>, netdev@...r.kernel.org,
	"Denis V. Lunev" <den@...nvz.org>,
	"David S. Miller" <davem@...emloft.net>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>
Subject: Re: Regression in current git - Network Manager fails (bisected)

Thomas Graf wrote:
> * Dan Williams <dcbw@...hat.com> 2007-10-22 11:57
>> On Mon, 2007-10-22 at 13:22 +0400, Denis V. Lunev wrote:
>>> We have spent some time with the problem with Alexey and there are no 
>>> guesses for now.
>>>
>>> Is it possible to name exact version of Network Manager and all 
>>> libraries related + provide us an output of strace with full buffers 
>>> send/received from netlink. Something like
>>>      strace -v -x -s 32768 <nm>
>> NM uses netlink in two places; libnl (from Thomas Graf) and some custom
>> code for listening for interface up/down events and wireless events.
>>
>> It looks like that code comes from libnl's lib/handlers.c where it
>> thinks the received message is invalid.
>>
>> I'm pretty sure the code that checks carrier status of the device isn't
>> libnl code; so maybe the error message (which should get fixed of
>> course) isn't in the same path as the link detection.
>>
>> The link detection comes from src/nm-netlink-monitor.c, so maybe we
>> should look at debugging there.
> 
> The patch introduced a change in semantics because it removed the
> special ACK handling after a dump was started.
> 
> I will look into this.
> 

I have reproduced the problem with one-line test.
     ./nl-route-get 192.168.1.1
The problem is with this message:

-- Debug: Sent Message:
--------------------------   BEGIN NETLINK MESSAGE 
---------------------------
   [HEADER] 16 octets
     .nlmsg_len = 20
     .nlmsg_type = 18 <route/link>
     .nlmsg_flags = 773 <REQUEST,ACK,ROOT,MATCH>
     .nlmsg_seq = 1193143772
     .nlmsg_pid = 8233
   [PAYLOAD] 16 octets
     00 1d fa 20 00 00 00 00 81 0e 02 00 00 00 00 00       ... ............
---------------------------  END NETLINK MESSAGE 
---------------------------
it starts dump and requests ACK.

Regards,
	Den
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html