lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 23 Oct 2007 16:38:06 +0200 From: Patrick McHardy <kaber@...sh.net> To: Andreas Henriksson <andreas@...al.se> CC: maximilian attems <max@...o.at>, shemminger@...ux-foundation.org, netdev@...r.kernel.org Subject: Re: iproute2: git pull request from debian repo. Andreas Henriksson wrote: > On Sun, Oct 21, 2007 at 07:48:21PM +0200, Patrick McHardy wrote: >> Andreas Henriksson wrote: >>> - for (;;) { >>> + while (round < MAX_ROUNDS) { >>> if (rtnl_wilddump_request(&rth, filter.family, >>> RTM_GETADDR) < 0) { >>> perror("Cannot send dump request"); >>> exit(1); >>> @@ -694,6 +696,8 @@ int ipaddr_list_or_flush(int argc, char **argv, int >>> flush) >>> fflush(stdout); >>> } >>> } >>> + fprintf(stderr, "*** Flush remains incomplete after %d >>> rounds. ***\n", MAX_ROUNDS); fflush(stderr); >> >> Again, please make this optional. People might want to make >> sure the cache is flushed even if it takes a bit longer. > > And here's the alternativ with configurable max rounds (0=infinite)... Almost - the default behaviour shouldn't change IMO. Also please send a complete patch, not one on top of your old one. > > - while (round < MAX_ROUNDS) { > + while ((maxrounds == 0) || (round < maxrounds)) { And please remove the unnecessary parens. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists