lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 23 Oct 2007 10:20:35 -0500 From: Josh Boyer <jwboyer@...ux.vnet.ibm.com> To: Jeff Garzik <jeff@...zik.org> Cc: Valentine Barshak <vbarshak@...mvista.com>, Michael Ellerman <michael@...erman.id.au>, linuxppc-dev@...abs.org, netdev@...r.kernel.org Subject: Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC. On Mon, 15 Oct 2007 14:27:23 -0400 Jeff Garzik <jeff@...zik.org> wrote: > Valentine Barshak wrote: > > This patch adds BCM5248 and Marvell 88E1111 PHY support to NEW EMAC driver. > > These PHY chips are used on PowerPC 440EPx boards. > > The PHY code is based on the previous work by Stefan Roese <sr@...x.de> > > > > Signed-off-by: Stefan Roese <sr@...x.de> > > Signed-off-by: Valentine Barshak <vbarshak@...mvista.com> > > --- > > drivers/net/ibm_newemac/phy.c | 39 +++++++++++++++++++++++++++++++++++++++ > > 1 files changed, 39 insertions(+) > > > > --- linux.orig/drivers/net/ibm_newemac/phy.c 2007-06-15 21:45:18.000000000 +0400 > > +++ linux/drivers/net/ibm_newemac/phy.c 2007-06-15 20:45:15.000000000 +0400 > > @@ -306,8 +306,47 @@ > > .ops = &cis8201_phy_ops > > }; > > > > +static struct mii_phy_def bcm5248_phy_def = { > > + > > + .phy_id = 0x0143bc00, > > + .phy_id_mask = 0x0ffffff0, > > + .name = "BCM5248 10/100 SMII Ethernet", > > + .ops = &generic_phy_ops > > +}; > > + > > +static int m88e1111_init(struct mii_phy *phy) > > +{ > > + printk("%s: Marvell 88E1111 Ethernet\n", __FUNCTION__); > > + phy_write(phy, 0x14, 0x0ce3); > > + phy_write(phy, 0x18, 0x4101); > > + phy_write(phy, 0x09, 0x0e00); > > + phy_write(phy, 0x04, 0x01e1); > > + phy_write(phy, 0x00, 0x9140); > > + phy_write(phy, 0x00, 0x1140); > > + > > + return 0; > > +} > > + > > +static struct mii_phy_ops m88e1111_phy_ops = { > > + .init = m88e1111_init, > > + .setup_aneg = genmii_setup_aneg, > > + .setup_forced = genmii_setup_forced, > > + .poll_link = genmii_poll_link, > > + .read_link = genmii_read_link > > +}; > > + > > +static struct mii_phy_def m88e1111_phy_def = { > > + > > + .phy_id = 0x01410CC0, > > + .phy_id_mask = 0x0ffffff0, > > + .name = "Marvell 88E1111 Ethernet", > > + .ops = &m88e1111_phy_ops, > > +}; > > + > > static struct mii_phy_def *mii_phy_table[] = { > > &cis8201_phy_def, > > + &bcm5248_phy_def, > > + &m88e1111_phy_def, > > &genmii_phy_def, > > Seems sane to me -- ACK -- but we have multiple people sending me > patches for a single driver. That's normal for janitorial cleanups > across the whole tree, but discouraged when multiple people are actively > working on the same driver. > > Please coordinate, and have ONE person send me patches... Jeff, could you please pull in this patch for 2.6.24? We'll get the coordination down for any further patches. thx, josh > - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists