netdev - Re: [PATCH] [POWERPC] ucc_geth: Eliminate compile warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071023171005.GA4638@loki.buserror.net>
Date:	Tue, 23 Oct 2007 12:10:05 -0500
From:	Scott Wood <scottwood@...escale.com>
To:	Medve Emilian-EMMEDVE1 <Emilian.Medve@...escale.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	jgarzik@...ox.com, linuxppc-dev@...abs.org
Subject: Re: [PATCH] [POWERPC] ucc_geth: Eliminate compile warnings

On Mon, Oct 22, 2007 at 06:47:32AM -0700, Medve Emilian-EMMEDVE1 wrote:
> Are you suggesting we leave those warnings there until somebody decides
> to fix all the portability issues of this driver? My patch is a small
> and insignificant improvement and not the revolution you're asking for,
> but is an small improvement today (I dislike warnings) vs. an improbable
> big one in the future.

It is not an improvement, as it moves the driver further away from being
64-bit clean.  A better fix would be to change the definition of
tx/rx_bd_ring_offset to unsigned long (or better yet, a union).

-Scott
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html