netdev - Re: [PATCH 2/2] NFS: handle IPv6 addresses in nfs ctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <471F9B73.4010908@hp.com>
Date:	Wed, 24 Oct 2007 15:22:27 -0400
From:	Brian Haley <brian.haley@...com>
To:	Aurélien Charbon <aurelien.charbon@....bull.net>
Cc:	Mailing list NFSv4 <nfsv4@...ux-nfs.org>,
	netdev ML <netdev@...r.kernel.org>
Subject: Re: [PATCH 2/2] NFS: handle IPv6 addresses in nfs ctl

Hi Aurelien,

Again, a few more comments.

I might just modify these in my own tree and send out a patch that 
combines both into one, it might be less work.

> @@ -229,9 +229,20 @@ static ssize_t write_getfs(struct file *
>  		return -EINVAL;
>  	data = (struct nfsctl_fsparm*)buf;
>  	err = -EPROTONOSUPPORT;
> -	if (data->gd_addr.sa_family != AF_INET)
> +	switch (data->gd_addr.sa_family) {
> +	case AF_INET6:
> +		sin6 = &sin6_storage;

This should be:

	in6 = &sin6_storage;

> +		sin6 = (struct sockaddr_in6 *)&data->gd_addr;
> +		ipv6_addr_copy(&in6, &(sin6->sin6_addr)); 

Extra () here.

> -    	if (!(clp = auth_unix_lookup(in6))) 
> +	switch (data->gd_addr.sa_family) {
> +	case AF_INET:
> +		/* IPv6 address mapping */
> +		ipv6_addr_set(&in6, 0, 0, htonl(0x0000FFFF), ((struct sockaddr_in *)&data->gd_addr)->sin_addr.s_addr);
> +		break;
> +	case AF_INET6:
> +		sin6 = &sin6_storage;

This should be:

	in6 = &sin6_storage;

> +		sin6 = (struct sockaddr_in6 *)&data->gd_addr;
> +		ipv6_addr_copy(&in6, &(sin6->sin6_addr));

Extra () here.

-Brian
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html