| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 25 Oct 2007 13:51:19 +0200
From: Lennert Buytenhek <buytenh@...tstofly.org>
To: Jeff Garzik <jeff@...zik.org>
Cc: netdev@...r.kernel.org, tzachi@...vell.com, nico@....org
Subject: Re: [PATCH,RFC] Marvell Orion SoC ethernet driver
On Thu, Oct 25, 2007 at 05:12:04AM -0400, Jeff Garzik wrote:
> >+struct rx_desc {
> >+ u32 cmd_sts;
> >+ u16 size;
> >+ u16 count;
> >+ u32 buf;
> >+ u32 next;
> >+};
> >+
> >+struct tx_desc {
> >+ u32 cmd_sts;
> >+ u16 l4i_chk;
> >+ u16 count;
> >+ u32 buf;
> >+ u32 next;
> >+};
>
> should use sparse type (__le32, etc.) and make sure this driver passes
> sparse checks
>
> ditto for checkpatch (except for the excessively anal stuff)
Sorry if it wasn't clear from the thread -- the mainline mv643xx_eth
driver turns out to support the same silicon block (but as part of a
different chip), so we've dropped orion_eth and submitted patches to
make mv643xx_eth work on both the Discovery (what it was originally
written for) and the Orion, and these patches are in -rc1 already.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists