netdev - Re: [PATCH 1/4] e1000e: Fix jumbo frame receive code.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47210525.4020606@intel.com>
Date:	Thu, 25 Oct 2007 14:05:41 -0700
From:	"Kok, Auke" <auke-jan.h.kok@...el.com>
To:	jeff@...zik.org
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/4] e1000e: Fix jumbo frame receive code.

Auke Kok wrote:
> Fix allocation and freeing of jumbo frames where several bugs
> were recently introduced by cleanups after we forked this code
> from e1000. This moves ps_pages to buffer_info where it really
> belongs and makes it a dynamically allocated array. The penalty
> is not that high since it's allocated outside of the buffer_info
> struct anyway.
> 
> Without this patch all jumbo frames are completely broken and the
> driver panics.

Jeff,

I strongly suggest that you apply patches #1 and #2 (but preferably all) to
#upstream-fixes since these patches fix the -absolutely- broken jumbo frames code
in e1000e. On top of that patches #1 and #2 only touch the jumbo frame codepath,
so the impact is zero to the normal way people use these cards.

patch #3 is an optimization, patch #4 is mostly cosmetical.

Cheers,

Auke
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html