netdev - Re: [PATCH v4.2] FEC - fast ethernet controller for mpc52xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071026141828.GA14900@xyzzy.farnsworth.org>
Date:	Fri, 26 Oct 2007 07:18:28 -0700
From:	"Dale Farnsworth" <dale@...nsworth.org>
To:	Domen Puncer <domen.puncer@...argo.com>
Cc:	Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org,
	linuxppc-dev@...abs.org
Subject: Re: [PATCH v4.2] FEC - fast ethernet controller for mpc52xx

On Fri, Oct 26, 2007 at 01:59:09PM +0200, Domen Puncer wrote:
> +static irqreturn_t mpc52xx_fec_tx_interrupt(int irq, void *dev_id)
> +{
> +	struct net_device *dev = dev_id;
> +	struct mpc52xx_fec_priv *priv = netdev_priv(dev);
> +
> +	spin_lock(&priv->lock);
> +
> +	while (bcom_buffer_done(priv->tx_dmatsk)) {
> +		struct sk_buff *skb;
> +		struct bcom_fec_bd *bd;
> +		skb = bcom_retrieve_buffer(priv->tx_dmatsk, NULL,
> +				(struct bcom_bd **)&bd);
> +		/* Here (and in rx routines) would be a good place for
> +		 * dma_unmap_single(), but bcom doesn't return bcom_bd of the
> +		 * finished transfer, and _unmap is empty on this platfrom.
> +		 */

Oops, you forgot to remove the above comment.  :)

Otherwise,
Acked-by: Dale Farnsworth <dale@...nsworth.org>

Domen, thanks for all your work on this.  It's good to see it finally go in.

-Dale
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html