netdev - Re: [PATCH] proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071028084441.GA24221@uranus.ravnborg.org>
Date:	Sun, 28 Oct 2007 09:44:41 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Alexey Dobriyan <adobriyan@...il.com>, akpm@...l.org,
	torvalds@...l.org, viro@...iv.linux.org.uk,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	linux-arch@...r.kernel.org
Subject: Re: [PATCH] proc_fs.h redux

> 
> As a general rule, I think it better to use includes
> than use naked forward declarations.

Quite the opposite - at least in the kernel source.
The general rule is that a .h file shall include the
.h files which contain declarations used by said .h files.
But naked declarations as above is preferred over including
a full header file.

We see the full header dependency thing to blow off when
inline function are used - which is more and more the case.
In several cases we have converted inline functions to macros
just to simplify the nightmare of header dependencies we have.

Arnaldo have a nice script that generate a .ps file
showing all the dependencies.
He lately posted this URL: http://oops.ghostprotocols.net:81/acme/tcp.h.ps

	Sam
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html