netdev - Re: [PATCH 2.6.24 1/1]S2io: Fixed memory leak by freeing MSI-X local entry memories when vector allocation fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4725AE20.7000400@garzik.org>
Date:	Mon, 29 Oct 2007 05:55:44 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Sivakumar Subramani <Sivakumar.Subramani@...erion.com>
CC:	netdev@...r.kernel.org, support@...erion.com
Subject: Re: [PATCH 2.6.24 1/1]S2io: Fixed memory leak by freeing MSI-X local
 entry memories when vector allocation fails

Sivakumar Subramani wrote:
> - Fixed memory leak by freeing MSI-X local entry memories when vector allocation
> fails in s2io_add_isr.
> - Added two utility functions do_rem_msix_isr and do_rem_inta_isr to eliminate
> code duplication.
> 
> Signed-off-by: Veena Parat <veena.parat@...erion.com>
> Signed-off-by: Ramkrishna Vepa <ram.vepa@...erion.com>
> Signed-off-by: Santosh Rastapur <santosh.rastapur@...erion.com>

Comments:

1) stats->mem_freed is redundant to general kernel debugging facilities

2) synchronize_irq() is redundant, free_irq() does same

3) "rem" isn't very clear.  few if any other kernel drivers use this to 
indicate "remove"

4) "do_" prefix is redundant

5) scripts/checkpatch.pl fails on this patch.  please clean up problems.

The main issue for this patch is #2, though presumably the other stuff 
can be cleaned on the next resubmit


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html