netdev - Re: HFSC dangerous behaviour (not a bug)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4725BC23.7000907@trash.net>
Date:	Mon, 29 Oct 2007 11:55:31 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	Denys <denys@...p.net.lb>
CC:	netdev@...r.kernel.org
Subject: Re: HFSC dangerous behaviour (not a bug)

Denys wrote:
> Hi All
> 
> During testing i found very strange thing. 
> After applying even example shaper:
> http://linux-ip.net/tc/hfsc.en/
> -------------
> [...]
> ---------------
> I had all traffic on eth0 stopped. Tried on br0 - same result. Even ARP 
> becoming non-functional.
> 
> After specifying correct default class everything worked fine.
> 
> In HTB if you dont specify default class, traffic just pass without 
> "shaping". 


HFSC drops unclassified packets. If you don't classify ARP properly,
things will break,

> Is it possible to keep same behaviour on both disciplines?
> Probably just dropping all traffic not good idea, cause if user working on 
> remote box by forgetting specifying default class or by mistake using 
> incorrect class number he will loose access to the box, if same interface is 
> used for tests on shaping and access.
> In same time it is good, and can show accurate results on shaping, without 
> bypassing some "forgotten" traffic.
> But at least it must be same, IMHO, on HTB and HFSC.


This came up a couple of times already. I don't like HTB's behaviour
since you don't notice when your classifiers are incomplete. So I'm
against changing HFSC to behave similar. HTB OTOH can't be changed
since users probably rely on that, not classifying ARP is a common
mistake.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html