netdev - Re: [PATCH] pcnet: fix sparse triviality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47261E51.2000301@intel.com>
Date:	Mon, 29 Oct 2007 10:54:25 -0700
From:	"Kok, Auke" <auke-jan.h.kok@...el.com>
To:	Jeff Garzik <jeff@...zik.org>
CC:	pcnet32@...izon.net, netdev@...r.kernel.org
Subject: Re: [PATCH] pcnet: fix sparse triviality

Jeff Garzik wrote:
> Auke Kok wrote:
>> Since data can never exceed u32, it can't even be larger than
>> LONG_MAX/HZ.
>>
>> Signed-off-by: Auke Kok <auke-jan.h.kok@...el.com>
>> Cc: pcnet32@...izon.net
>> ---
>>
> Two comments:
> 
> 1) I would prefer to pick a sane limit, like "1 day".  The unit of
> 'data' is seconds, so IMO we should not allow stupid timeouts, much less
> INT_MAX ones :)  But hey, then again, maybe we should permit root to
> hang themselves with own rope...

well, in this case it's only used for the blink interval for the LED on the back
of the adapter. This is completely interruptable by the user with ^C when running
ethtool, so it's not going to hang anything (traffic should continue nicely).

yes INT_MAX is insanely long. moving all of this checking to the ethtool generic
code makes much more sense indeed.

> 2) [tangent] someone really should add the obvious ssleep_interruptible()

*pass* :)

Auke
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html