lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 29 Oct 2007 15:33:20 +0900 From: Mitsuru Chinen <mitch@...ux.vnet.ibm.com> To: Herbert Xu <herbert@...dor.apana.org.au> Cc: "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org> Subject: Re: [UDP6]: Restore sk_filter optimisation Hello Herbert, Let me ask a question about this patch. After this patch was applied, 2 of the protocol stack behaviors were changed when it receives a UDP datagram with broken checksum: 1. udp6InDatagrams is incremented instead of udpInErrors 2. In userland, recvfrom() replies an error with EAGAIN. recvfrom() wasn't aware of such a packet before. Are these changes intentional? Best Regards, ---- Mitsuru Chinen <mitch@...ux.vnet.ibm.com> On Tue, 6 Mar 2007 12:20:10 +1100 Herbert Xu <herbert@...dor.apana.org.au> wrote: > Hi Dave: > > [UDP6]: Restore sk_filter optimisation > > This reverts the changeset > > [IPV6]: UDPv6 checksum. > > We always need to check UDPv6 checksum because it is mandatory. > > The sk_filter optimisation has nothing to do whether we verify the > checksum. It simply postpones it to the point when the user calls > recv or poll. > > Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au> > > Cheers, > -- > Visit Openswan at http://www.openswan.org/ > Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au> > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt > -- > diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c > index 0ad4719..4474480 100644 > --- a/net/ipv6/udp.c > +++ b/net/ipv6/udp.c > @@ -279,8 +279,10 @@ int udpv6_queue_rcv_skb(struct sock * sk, struct sk_buff *skb) > } > } > > - if (udp_lib_checksum_complete(skb)) > - goto drop; > + if (sk->sk_filter) { > + if (udp_lib_checksum_complete(skb)) > + goto drop; > + } > > if ((rc = sock_queue_rcv_skb(sk,skb)) < 0) { > /* Note that an ENOMEM error is charged twice */ - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists