lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 30 Oct 2007 15:17:54 +0100 From: Jens Axboe <jens.axboe@...cle.com> To: Herbert Xu <herbert@...dor.apana.org.au> Cc: "David S. Miller" <davem@...emloft.net>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Linux Crypto Mailing List <linux-crypto@...r.kernel.org>, netdev@...r.kernel.org Subject: Re: [PATCH 1/2] [CRYPTO] tcrypt: Move sg_init_table out of timing loops On Tue, Oct 30 2007, Herbert Xu wrote: > On Tue, Oct 30, 2007 at 06:50:58AM +0100, Jens Axboe wrote: > > > > How so? The reason you changed it to sg_init_table() + sg_set_buf() is > > exactly because sg_init_one() didn't properly init the entry (as they > > name promised). > > For one of the cases yes but the other one repeatedly calls > sg_init_one on the same sg entry while we really only need > to initialise it once and call sg_set_buf afterwards. > > Normally this is irrelevant but the loops in question are > trying to estimate the speed of the algorithms so it's good > to exclude as much noise from them as possible. Ah OK, I was referring to the replacement mentioned above. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists