lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Tue, 30 Oct 2007 09:12:11 -0700
From:	"Kok, Auke" <auke-jan.h.kok@...el.com>
To:	Andy Gospodarek <andy@...yhouse.net>
CC:	zenyowu@...ibm.com, netdev@...r.kernel.org
Subject: Re: [PATCH 2.6.24] ixgb: TX hangs under heavy load

Andy Gospodarek wrote:
> Auke,
> 
> It has become clear that this patch resolves some tx-lockups on the ixgb
> driver.  IBM did some checking and realized this hunk is in your
> sourceforge driver, but not anywhere else.  Mind if we add it?


I'll quickly double check where this came from in the first place and will post
this to Jeff

Thanks!

Auke


> Signed-off-by: Andy Gospodarek <andy@...yhouse.net>
> 
> ---
> 
>  ixgb_main.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c
> index d444de5..3ec7a41 100644
> --- a/drivers/net/ixgb/ixgb_main.c
> +++ b/drivers/net/ixgb/ixgb_main.c
> @@ -1324,7 +1324,7 @@ ixgb_tx_map(struct ixgb_adapter *adapter, struct sk_buff *skb,
>  
>  			/* Workaround for premature desc write-backs
>  			 * in TSO mode.  Append 4-byte sentinel desc */
> -			if (unlikely(mss && !nr_frags && size == len
> +			if (unlikely(mss && (f == (nr_frags-1)) && size == len
>  			             && size > 8))
>  				size -= 4;
>  
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists