netdev - Re: [PATCH 10/14 v2] nes: eeprom and phy routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ada1wbbghe2.fsf@cisco.com>
Date:	Wed, 31 Oct 2007 13:26:29 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	ggrundstrom@...effect.com
Cc:	ewg@...ts.openfabrics.org, general@...ts.openfabrics.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 10/14 v2] nes: eeprom and phy routines

 > +	/* TODO: deal with EEPROM endian issues */

This is pretty scary.  Is the driver broken on big-endian systems now?

 > +/*
 > +"Everything you wanted to know about CRC algorithms, but were afraid to ask
 > + for fear that errors in your understanding might be detected." Version  : 3.

etc etc... can all this be replaced with what's in lib/crc32.c?  (I
hope so)

 - R.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html