lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 31 Oct 2007 23:05:45 +0900 From: Mitsuru Chinen <mitch@...ux.vnet.ibm.com> To: Herbert Xu <herbert@...dor.apana.org.au> Cc: "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org> Subject: Re: [UDP6]: Restore sk_filter optimisation On Mon, 29 Oct 2007 20:53:28 +0800 Herbert Xu <herbert@...dor.apana.org.au> wrote: > On Mon, Oct 29, 2007 at 03:33:20PM +0900, Mitsuru Chinen wrote: > > Hello Herbert, > > > > Let me ask a question about this patch. > > After this patch was applied, 2 of the protocol stack behaviors were > > changed when it receives a UDP datagram with broken checksum: > > > > 1. udp6InDatagrams is incremented instead of udpInErrors > > 2. In userland, recvfrom() replies an error with EAGAIN. > > recvfrom() wasn't aware of such a packet before. > > > > Are these changes intentional? > > It wasn't my intention if that's what you mean :) > > However, this would've happened with the old code anyway if > someone had a filter attached so this isn't new. > > If it's a problem then we should just get it fixed. As far as I tested, this doesn't happen with the old code even if a filter is attached. However, this happen with the new code without a filter and I don't see this rather when a filter is attached. So, I'm afraid it's new. By the way, could you answer the Yoshifuji-san's question? I think the code where we should fix depends on this. On Mon, 29 Oct 2007 15:41:50 +0900 (JST) YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@...ux-ipv6.org> wrote: > And, we're not sure how much the "optimization"'s benefit is. > It is even worse when we are handling multicast packets. Thank you, ---- Mitsuru Chinen <mitch@...ux.vnet.ibm.com> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists