netdev - Re: [PATCH v4] FEC - fast ethernet controller for mpc52xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <41915.213.186.37.16.1193916684.squirrel@www.opensources.be>
Date:	Thu, 1 Nov 2007 12:31:24 +0100 (CET)
From:	tnt@...cksnow.net
To:	"Domen Puncer" <domen.puncer@...argo.com>
Cc:	"Jeff Garzik" <jgarzik@...ox.com>,
	"Grant Likely" <grant.likely@...retlab.ca>,
	galak@...nel.crashing.org, linuxppc-dev@...abs.org, tnt@...tnt.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH v4] FEC - fast ethernet controller for mpc52xx

> +	while (bcom_buffer_done(priv->tx_dmatsk)) {
> +		struct sk_buff *skb;
> +		skb = bcom_retrieve_buffer(priv->tx_dmatsk, NULL, NULL);
> +		/* Here (and in rx routines) would be a good place for
> +		 * dma_unmap_single(), but bcom doesn't return bcom_bd of the
> +		 * finished transfer, and _unmap is empty on this platfrom.
> +		 */
> +

Of course bestcomm let's you get back the bcom_bd ... What do you think
your second NULL parameter is for ?
Give it a pointer to a bcom_bd * and it will fill your pointer for you to
point to the bd you just got back.


   Sylvain

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html