netdev - Re: [PATCH 2/2] [POWERPC] Fix region size check in mpc5200 FEC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fa686aa40711011125w4df3b1b9r1693bdfec84dd281@mail.gmail.com>
Date:	Thu, 1 Nov 2007 12:25:36 -0600
From:	"Grant Likely" <grant.likely@...retlab.ca>
To:	"Ingo Oeser" <netdev@...eo.de>
Cc:	netdev@...r.kernel.org, jgarzik@...ox.com, domen.puncer@...argo.com
Subject: Re: [PATCH 2/2] [POWERPC] Fix region size check in mpc5200 FEC driver

On 11/1/07, Ingo Oeser <netdev@...eo.de> wrote:
> Hi Grant,
>
> Grant Likely schrieb:
> > From: Grant Likely <grant.likely@...retlab.ca>
> >
> > Driver shouldn't complain if the register range is larger than what
> > it expects.  This works around failures with some device trees.
> >
>
> But maybe the firmware guys like to know about it?
> May I suggest putting this in front of the other check?
>
> if ((mem.end - mem.start + 1) > sizeof(struct mpc52xx_fec)) {
>                 printk(KERN_DEBUG DRIVER_NAME
>                         " - gratious resource size (%lx > %x), check mpc52xx_devices.c\n",
>                         (unsigned long)(mem.end - mem.start + 1), sizeof(struct mpc52xx_fec));

Personally, I'm not concerned about it.  Even if the device tree says
the range is larger than what the driver knows about it is not
technically an error. If a new version of the chip appears that is
compatible, but defines a larger register range with extra feature
registers, then this message would be erroneously printed.  Finally,
depending on how you read the mpc5200 user guild, it can be 100% valid
to specify the reg size as 0x800 instead of 0x400.

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@...retlab.ca
(403) 399-0195
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html