lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 2 Nov 2007 11:03:04 -0500 From: Olof Johansson <olof@...om.net> To: Stefan Roese <sr@...x.de> Cc: netdev@...r.kernel.org, linuxppc-dev@...abs.org, benh@...nel.crashing.org, jwboyer@...ux.vnet.ibm.com Subject: Re: [PATCH] net: Add 405EX support to new EMAC driver On Fri, Nov 02, 2007 at 08:14:43AM +0100, Stefan Roese wrote: > This patch adds support for the 405EX to the new EMAC driver. Some as on > AXON, the 405EX handles the MDIO via the RGMII bridge. Hi, This isn't feedback on your patch as much as on "new-emac" in general: Isn't this the case where there should really be device tree properties instead? If you had an "ibm,emac-has-axon-stacr" property in the device node, then you don't have to modify the driver for every new board out there. Same for the other device properties, of course. I thought this was what having the device tree was all about. :( -Olof - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists