netdev - Re: Endianness problem with u32 classifier hash masks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1194270426.4438.100.camel@localhost>
Date:	Mon, 05 Nov 2007 08:47:06 -0500
From:	jamal <hadi@...erus.ca>
To:	Jarek Poplawski <jarkao2@...pl>
Cc:	Radu Rendec <radu.rendec@...s.ro>, netdev@...r.kernel.org
Subject: Re: Endianness problem with u32 classifier hash masks

On Mon, 2007-05-11 at 10:12 +0100, Jarek Poplawski wrote:

> BTW: when looking around this I think, maybe, in u32_change():
> 
> 1) if (--divisor > 0x100) should be probably ">=", 

Does it really matter? Divisor can be max of 0xff.

> but is it really needed to check this 2 times (including tc)?

I dont mind letting users shoot themselves in the foot by sending crap.
If it can be avoided with simplicity, then better.

> 2) this while() loop for n->fshift could be replaced with ffs()?

I think so. Can you please send a patch (after some testing of course
maybe using Radu's test data)?

cheers,
jamal

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html