netdev - Re: kernel panic removing devices from a teql queuing discipline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071105200800.GA4075@2ka.mipt.ru>
Date:	Mon, 5 Nov 2007 23:08:00 +0300
From:	Evgeniy Polyakov <johnpol@....mipt.ru>
To:	David Miller <davem@...emloft.net>
Cc:	cebbert@...hat.com, netdev@...r.kernel.org
Subject: Re: kernel panic removing devices from a teql queuing discipline

On Tue, Oct 30, 2007 at 01:33:41AM -0700, David Miller (davem@...emloft.net) wrote:
> > The panic is in __teql_resolve (which has been inlined into teql_master_xmit) in
> > net/sched/sch_teql.c at this line:
> > 
> > 	if (n && n->tbl == mn->tbl &&
> > 
> > Specifically the dereference of n->tbl is faulting as n is not valid.

n is never valid (null), mn is garbage.

> > And the address looks like part of an ASCCI string...  "figt"
> 
> I studied sch_teql.c a bit and I suspect that the slave list
> management in teql_destroy() and teql_qdisc_init() might be
> suspect.

tecl_reset() is called from deactivate and qdisc is set to noop already,
but subsequent teql_xmit does not know about it and dereference private
data as teql qdisc and thus oopses. I will fix it tomorrow if you will
not catch it first :)

-- 
	Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html