netdev - Re: [PATCH] add support for smc91x ethernet interface on zylonite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <alpine.LFD.0.9999.0711052235121.21255@xanadu.home>
Date:	Mon, 05 Nov 2007 22:37:56 -0500 (EST)
From:	Nicolas Pitre <nico@....org>
To:	eric miao <eric.y.miao@...il.com>
Cc:	Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] add support for smc91x ethernet interface on zylonite

On Tue, 6 Nov 2007, eric miao wrote:

> >From 9363662844b6373ddf4265e7007eb29ff963a377 Mon Sep 17 00:00:00 2001
> From: eric miao <eric.miao@...vell.com>

According to the SOB line below, shouldn't this be:
From: Aleksey Makarov <amakarov@...mvista.com>
?

> Date: Tue, 30 Oct 2007 09:48:41 +0800
> Subject: [PATCH] add support for smc91x ethernet interface on zylonite
> 
> This patch adds LAN91C111 ethernet interface support for zylonite
> (a.k.a Marvell's PXA3xx Development Platform) with smc91x driver.
> 
> It would be better if a patch would support zylonite along with all
> other PXA boards with a single binary of smc91x driver, but it looks
> quite difficult for the moment, so ugly #ifdef is still used here.
> 
> Signed-off-by: Aleksey Makarov <amakarov@...mvista.com>
> Acked-by: eric miao <eric.miao@...vell.com>

Acked-by: Nicolas Pitre <nico@....org>

> ---
>  drivers/net/smc91x.h |   15 +++++++++++++++
>  1 files changed, 15 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/smc91x.h b/drivers/net/smc91x.h
> index 729fd28..db34e1e 100644
> --- a/drivers/net/smc91x.h
> +++ b/drivers/net/smc91x.h
> @@ -224,6 +224,21 @@ SMC_outw(u16 val, void __iomem *ioaddr, int reg)
>  	}
>  }
> 
> +#elif defined(CONFIG_MACH_ZYLONITE)
> +
> +#define SMC_CAN_USE_8BIT        1
> +#define SMC_CAN_USE_16BIT       1
> +#define SMC_CAN_USE_32BIT       0
> +#define SMC_IO_SHIFT            0
> +#define SMC_NOWAIT              1
> +#define SMC_USE_PXA_DMA		1
> +#define SMC_inb(a, r)           readb((a) + (r))
> +#define SMC_inw(a, r)           readw((a) + (r))
> +#define SMC_insw(a, r, p, l)    insw((a) + (r), p, l)
> +#define SMC_outsw(a, r, p, l)   outsw((a) + (r), p, l)
> +#define SMC_outb(v, a, r)       writeb(v, (a) + (r))
> +#define SMC_outw(v, a, r)       writew(v, (a) + (r))
> +
>  #elif	defined(CONFIG_ARCH_OMAP)
> 
>  /* We can only do 16-bit reads and writes in the static memory space. */
> -- 
> 1.5.2.5.GIT
> 


Nicolas
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html