netdev - Re: [PATCH 2.6.23] [PPP]: L2TP: Fix oops in transmit and receive paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 05 Nov 2007 23:33:15 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jchapman@...alix.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2.6.23] [PPP]: L2TP: Fix oops in transmit and receive
 paths

From: James Chapman <jchapman@...alix.com>
Date: Mon, 5 Nov 2007 17:17:39 GMT

> [PPP]: L2TP: Fix oops in transmit and receive paths
> 
> Changes made on 18-sep to fix skb handling in the pppol2tp driver
> broke the transmit and receive paths. Users are only running into this
> now because distros are now using 2.6.23 and I must have messed up
> when I tested the change.
> 
> For receive, we now do our own calculation of how much to pull from
> the skb (variable length L2TP header) rather than using
> skb_transport_offset(). Also, if the skb isn't a data packet, it must
> be passed back to UDP with skb->data pointing to the UDP header.
> 
> For transmit, make sure skb->sk is set up because ip_queue_xmit()
> needs it.
> 
> Signed-off-by: James Chapman <jchapman@...alix.com>

Applied, thanks James.

I'll queue this up for -stable too.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html